Repository navigation
[kotlin-spring] Tests only - Add regression tests and samples for generic interfaces in implements - #25633
Open
Picazsoo wants to merge 1 commit into
Conversation
…es in implements Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Picazsoo
marked this pull request as ready for review
November 11, 2026 16:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
x-kotlin-implementsandschemaImplementsinkotlin-springalready work with generic interfaces, because the interface string is emitted verbatim. Nothing guarded that behavior, so this PR adds regression coverage. There are no generator changes.Unit test:
generateModelsImplementingGenericInterfacesuses a new spec,generic-interfaces-implements.yaml. It asserts the full supertype line for these cases:x-kotlin-implementsandschemaImplements(single-string and list values)Compile-checked samples:
Taginpetstore-with-x-kotlin-implements.yamlusesx-kotlin-implementswithGenericRepo<Category>andGenericPair<kotlin.String, org.openapitools.model.Category>.Orderin thekotlin-springboot-x-kotlin-implementssample usesschemaImplementswithBoundedRepo<kotlin.Long>,VariantSource<kotlin.collections.List<Tag>>andTwoBounds<kotlin.Int>.outvariance andwhereclauses.kotlin-springboot-x-kotlin-implementsandkotlin-springboot-include-http-request-context-delegatewere regenerated (the latter shares the spec). Both compile withmvnw compile.Known limitation (not changed here): no imports are generated for implemented interfaces or their type arguments. Types outside the model package must be fully qualified.
Testing
./mvnw test -pl modules/openapi-generator -Dtest='KotlinSpringServerCodegenTest#generateModelsImplementingGenericInterfaces+generateSerializableModelWithSchemaImplements': passed (2 tests)../mvnw -f samples/server/petstore/kotlin-springboot-x-kotlin-implements/pom.xml compile: success../mvnw -f samples/server/petstore/kotlin-springboot-include-http-request-context-delegate/pom.xml compile: success.batchcommand. I did not run the fullgenerate-samples.shorexport_docs_generators.sh; no option descriptions changed.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Adds regression coverage proving
x-kotlin-implementsandschemaImplementsinkotlin-springemit generic interface strings verbatim. No generator changes; the behavior already worked but was unguarded.x-kotlin-implementsandschemaImplements.x-kotlin-implements(Tag) andschemaImplements(Order), with hand-written interfaces covering bounds,outvariance, andwhereclauses.Written for commit dff5d80. Summary will update on new commits.